#221 Initial design for directory functionality

[pinaf]

For #221

• added class TkDirCreate + unit test
• TkDir now takes instance of Base in constructor
• added interfaces Dir and Dirs
• added puzzle for other directory operations
• added puzzle for creation of a RqDir class for bridge between request and Dir

[pinaf]

@karato travis failure is unrelated to issue. see #299

[karato]

@pinaf Thanks for your pull request, let me find someone who can review it

[karato]

@krzyk review it

[krzyk]

@pinaf I have one comment regarding the todo

[pinaf]

@krzyk ok changed it. please take another look.

[krzyk]

@karato we are waiting for #299

[karato]

@karato we are waiting for #299

@krzyk yes, of course, we'll wait for #299

[krzyk]

@pinaf qulice fails with:

[ERROR] /src/main/java/com/nerodesk/takes/doc/TkDirCreate.java[50-50]: Perhaps 'base' could be replaced by a local variable. (SingularField)

[ERROR] /src/main/java/com/nerodesk/takes/doc/TkDirCreate.java[50-50]: Avoid unused private fields such as 'base'. (UnusedPrivateField)

[karato]

@pinaf we waited for #299, it is closed already

[k0r]

@yegor256 we might have to postpone this feature. directory implementation is going cause a few code challenges: directory deletion, moving files to another directory, and reorganizing files if the directory is deleted, etc. could be several tickets to scale this feature.

[k0r]

@yegor256 what do you think?

[yegor256]

@karato indeed, let's postpone this

[karato]

@karato indeed, let's postpone this

@yegor256 OK, I labeled it as "postponed" tag

[karato]

@karato indeed, let's postpone this

@yegor256 right, I'll try to find someone else for this task

[karato]

@longtimeago review it

[pinaf]

@k0r @yegor256 not sure this was intentional or not, but ever since I have been added to the nerodesk team I have permission to merge the pull request...

[k0r]

@pinaf nerodesk team has write permission.

[pinaf]

@k0r so it was intentional?

[k0r]

@pinaf #271

[yegor256]

@k0r please fix it. the team must have "read-only" permissions

[k0r]

@yegor256 fixed.

[yegor256]

@k0r you can also remove me and @karato from nerodesk-read team

[k0r]

@karato please, be careful with the labels.

[pinaf]

@yegor256 shall we proceed with CR ?

[longtimeago]

@pinaf good question .. I'm also waiting for the answer

[krzyk]

@yegor256 and why was it reassigned? I think it should have been unassigned completely until @k0r decides we should go with directories

[yegor256]

@longtimeago I think we should proceed, review and merge. It's a pull request, we shouldn't hold it open for long time. (no matter what the status of the project is)

[k0r]

@yegor256 what about this?

[yegor256]

@k0r my bad, I thought it's an issue, not a pull request. It's not a good practice to keep pull requests in "on hold" status for longer. It will "expire" and we'll seriously damage the motivation of its author. It's always better to merge, no matter how "bad" is the code (well, it has to pass rultor and code review, of course).

[k0r]

@yegor256 postponing the feature isn't intended to demotivate the programmer, it involves other challenges we've previously discussed here.

[yegor256]

@k0r yes, postponing a feature is perfectly fine, but it's a pull request, not a feature. there is already some code written.

[k0r]

@yegor256 thanks. proceed, if needed.

[krzyk]

@yegor256 in such case can we reassign it to back to me, as I already reviewed it and, the only thing that is left is saying "merge" :-)

[longtimeago]

@krzyk I don't mind :)

[pinaf]

@karato please assign @krzyk here

[pinaf]

@yegor256 could you assign @krzyk please?

[yegor256]

@karato assign @krzyk to this pls

[karato]

@karato assign @krzyk to this pls

@yegor256 OK. @krzyk the ticket is yours, please proceed

[krzyk]

@rultor merge pls

[rultor]

@rultor merge pls

@krzyk Thanks for your request. @yegor256 Please confirm this.

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

[karato]

@krzyk Thanks a lot, I just topped your account for 21 mins, transaction ID 58657984, total time was 1 hour and 5 mins... extra minutes for review comments (c=6)... +21 added to your rating, at the moment it is: +4684

[karato]

@rultor deploy now pls

[rultor]

@rultor deploy now pls

@karato OK, I'll try to deploy now. You can check the progress here

[rultor]

@rultor deploy now pls

@karato Done! FYI, the full log is here (took me 3min)