search

libreliodev / android

Android Customizable Reader - Librelio Digital Publishing Suite
www.librelio.com
226 stars 130 forks source link

Make it possible to include tabs with website, Facebook ... depending on application_.xml #153

Closed libreliodev closed 10 years ago

libreliodev commented 11 years ago

See http://stackoverflow.com/questions/15560698/how-place-webview-in-tab-with-action-bar-android

intrications commented 11 years ago

Where would the tabs be? On the main magazine grid view screen?

libreliodev commented 11 years ago

Yes, on the main magazine grid view

intrications commented 11 years ago

Couldn't/shouldn't this use the same Tabs.plist file that the iOS version uses rather than application_.xml?

libreliodev commented 11 years ago

We will finally not use tabs in order to be consistent with the Windows 8 version

libreliodev commented 10 years ago

cc @librelioniv

libreliodev commented 10 years ago

@intrications How do we use this new feature? We tried adding tabs.plist in the assets directory, but the corresponding tabs do not appear. Thanks.

intrications commented 10 years ago

@libreliodev Try naming it as Tabs.plist with a capital 'T'

libreliodev commented 10 years ago

Ok, it worked. @intrications : I was wondering, would it be possible to put the tabs inside the upper bar, instead of having 2 bars. That was the original idea I had in mind. @librelioniv, @libreliopre : any thoughts about this? 2014-03-13 14 46 41

intrications commented 10 years ago

@libreliodev Yes, by switching to using default Action Bar tabs. They will then fit into the Action Bar on larger tablets and appear below the Action Bar when on a smaller device like a phone.

libreliodev commented 10 years ago

@intrications thanks for the info; how do we switch to using default Action Bar tabs?

intrications commented 10 years ago

@libreliodev I will push the required changes.

intrications commented 10 years ago

Note this this change removes the requirement for the PagerSlidingTabStrip library.

Also, Android may decide to display the tabs as a dropdown sometimes if it thinks there isn't enough room for tabs. There is no way to control this.

screenshot_2014-03-13-14-29-36

libreliodev commented 10 years ago

@intrications This looks really better, thanks. Can you please remove the PagerSlidingTabStrip library from the repo?

2014-03-13 16 43 49

intrications commented 10 years ago

I think I already did in the last commit. On 13 Mar 2014 15:46, "Librelio Dev Team" notifications@github.com wrote:

@intrications https://github.com/intrications This looks really better, thanks. Can you please remove the PagerSlidingTabStrip library from the repo?

[image: 2014-03-13 16 43 49]https://f.cloud.github.com/assets/3107052/2411344/8c7d4a82-aac6-11e3-8873-e4238eb4a9ee.png

Reply to this email directly or view it on GitHubhttps://github.com/libreliodev/android/issues/153#issuecomment-37548875 .

libreliodev commented 10 years ago

@intrications Can you remind us where the list of tabs is stored?

libreliodev commented 10 years ago

@intrications It's OK, sorry. We will document that.