libreliodev / android

Android Customizable Reader - Librelio Digital Publishing Suite
www.librelio.com
226 stars 130 forks source link

Online videos no longer play properly #196

Closed libreliodev closed 10 years ago

libreliodev commented 10 years ago

This has been tested for Youtube, and is probably also true for Vimeo. This happens since we use a Webview for html links, instead of external app. This might be due to the fact that Webviews don't support redirections? Or is a specific setting needed? cc @intrications

intrications commented 10 years ago

Can you give me a issue/page number to quickly test? Is it no longer working on any device?

libreliodev commented 10 years ago

See https://github.com/libreliodev/android/issues/102 for a list of issues containing such videos. We will send you a password by e-mail to download these issues if needed.

We actually tested in ChevalMag 504 p98, but it is probably easier for you on Wind. We tested on Galaxy Tab, and I think the customer tested on a Nexus.

libreliodev commented 10 years ago

@intrications: In Cheval Mag (cf new version in Dropbox), the preview image is now shown, but when tapping on the play button, the video does not launch (whereas it does launch in the browser) 2013-11-18 13 39 15

intrications commented 10 years ago

It is trying to play a HTML5 video on my Nexus 7. I've no idea why it doesn't play. Trying to play video in a WebView is probably a really bad idea because each version of Android will have different versions of WebView and YouTube will probably try to play a Flash video sometimes rather than HTML5 which is no longer supported on newer versions of Android.

As I have suggested before, I would use the YouTube Android API for YouTube videos. Since you are using Google Play for in-app billing, all devices with the app will be compatible with it.

libreliodev commented 10 years ago

@intrications Thanks for the comment and suggestion. We will think about implementing the YouTube API, but we would then probably need to support also Vimeo and possibly DailyMotion, which is probably a a lot of work.

In the meantime, can you please:

intrications commented 10 years ago

This commit should catch links to videos but it is currently untested.

Vimeo is probably more reliable than YouTube in a WebView because I think it usually always uses HTML5. Not sure about DailyMotion. But the YouTube experience would be vastly improved.

libreliodev commented 10 years ago

This works fine. Many thanks @intrications