libreliodev / android

Android Customizable Reader - Librelio Digital Publishing Suite
www.librelio.com
226 stars 129 forks source link

Multi-level gridviews no longer available when using tabs #252

Closed libreliodev closed 10 years ago

libreliodev commented 10 years ago

Multi-level gridviews implemented in #166 do no seem to work since we implemented #153.

@intrications Can you check please?

cc @librelioniv

intrications commented 10 years ago

@libreliodev What is not working? I think some of the images aren't loading.

intrications commented 10 years ago

I think the problem is more likely to be to do with #245

libreliodev commented 10 years ago

@intrications

What is not working? I think some of the images aren't loading.

Yes, you're right.

I think the problem is more likely to be to do with #245

I think you're right again. Do you think this can be fixed?

intrications commented 10 years ago

@libreliodev Yes, it can be fixed. Two options come to mind:

a) Always store the images on the server. The images are cached so they won't be loaded repeatly. However, they can be updated without updating the app. Also, smaller APK sizes.

b) Check for images in the assets folder first. This is probably more backwards compatible with your current workflow which includes images in the assets folder.

Which would you prefer?

libreliodev commented 10 years ago

@intrications

Sorry for the late answer. Yes, option b) looks better. But I think anyway that the main issue is that for some reason the server images are correctly loaded. Probably a matter of relative references as implemented in our iOS app. As a reminder:

libreliodev commented 10 years ago

Successfully tested.