search

libreliodev / android

Android Customizable Reader - Librelio Digital Publishing Suite
www.librelio.com
226 stars 129 forks source link

Make it possible to add overlays only in a given orientation #296

Closed libreliodev closed 9 years ago

libreliodev commented 9 years ago

Similar to https://github.com/libreliodev/iOS/issues/119

cc @intrications

intrications commented 9 years ago

I'm not sure what "overlays" means. Does it mean things like the slideshows and videos?

libreliodev commented 9 years ago

@intrications

I'm not sure what "overlays" means. Does it mean things like the slideshows and videos?

Yes, that's the term used by Adobe, so we suggest using it now (instead of "enhancements" or "enrichments")

intrications commented 9 years ago

@libreliodev Is there an example to test this with?

libreliodev commented 9 years ago

@intrications

Is there an example to test this with?

Numero 162, page 2+3

intrications commented 9 years ago

Implemented but there may be out-of-memory issues #194

libreliodev commented 9 years ago

@intrications Indeed, there are out-of-memeory issues on an old Galaxy Tab. Can something be done?

intrications commented 9 years ago

I've tried switching to Picasso to load the images (which is a good idea anyway just for better code).

However, it doesn't seem to have improved the problem.

These are very large images we are displaying on top of the large images created to display the PDF. It is possible they are not being cleared out of memory correctly once they aren't on screen.

libreliodev commented 9 years ago

OK. I guess Crashlytics will tell us how critical the issue is.