search

libreliodev / android

Android Customizable Reader - Librelio Digital Publishing Suite
www.librelio.com
226 stars 130 forks source link

Outdated code #318

Closed sfilatovs closed 7 years ago

sfilatovs commented 8 years ago

Hi,

I've ran into multiple instances where app doesn't build or crashes due to the fact that code needs to be updated (starting with "target SDK", going to the "afollestad.material-dialogs:core:" being out of date and numerous other issues). I was wondering if you plan to update the code (I could make a more elaborate list of problems and some solutions I've found). Perhaps in the case you're not going to update, you could recommend another similar app that could be used.

Best, Stas

avittecoqDAJ commented 8 years ago

Hello Stas,

The update of the application is planned. If you want to help us out, feel free to contribute.

Best,

Antoine

sfilatovs commented 8 years ago

Great, I am not a coder at all, so I've been just googling errors I was getting when trying to get the code running and then rewriting some parts as suggested on Stack Exchange. I will post here a list with the changes I've made to get the code running (but haven't been able to simulate yet).

sfilatovs commented 8 years ago

So, here is the list of the changes i've made so far to get the code working. Note, I don't know if it's possible to make the code running with less changes, most likely yes. I've been changing three files: main\build.gradle appiraterAndroid\build.gradle main\src\script\custom.gradle Those are different build gradles. I am attaching the actual files (i've changed their names or convenience).

I've modified main\build.gradle in the following way: changed version of sdk and other parameters to 23, explicitly indicated dependencies for appcompatv7 and others. custom.gradle: i've copied the contents of the updated main/build.gradle into it as indicated here commenting out the "custom.gradle" part. appiraterAndroid/build.gradle: included newer version of afollestad and a repository for it as indicated here

see the attached files, they contain all the changes (they're in txt format though, so if you want to change your code you need to copy-paste the code, not replace the files)

appiraterAndroid-build.txt main-build.txt main-src-script-custom.txt

.

zh-wowtv commented 7 years ago

I also want to contribute. But I'm using Android Studio. Is that OK?

avittecoqDAJ commented 7 years ago

Hello,

Yes it's okay.

avittecoqDAJ commented 7 years ago

Fixed by adae10ae3c4a621a72891c02b2ba62b47d572efc