libremesh / chef

Online ImageBuilder for OpenWrt/LibreMesh
https://chef.libremesh.org/
GNU Affero General Public License v3.0
78 stars 31 forks source link

change i10n to i18n #42

Closed patogit closed 6 years ago

patogit commented 6 years ago

i18n is internationalization, and l10n is localization -- i10n is neither. I chose i18n, since that's the directory name in some of the other libremesh software.

aparcar commented 6 years ago

@patogit thanks for the PR. However you somehow messed up the PR so I did the changes manually :)

patogit commented 6 years ago

What was messed up about it? I'm just learning to use git, so anything you can explain will help me learn.

aparcar commented 6 years ago

@patogit sorry for the short reply. You renamed a folder without moving the newly introduced file qqq.json as well. That can happen when using an outdated branch. With now claim of completeness, my usual approach for PRs:

using the origin master branch result in up to date source before branching. Hope that helps somehow. More fun begins if you have a look at git rebase -i