search

libremesh / chef

Online ImageBuilder for OpenWrt/LibreMesh
https://chef.libremesh.org/
GNU Affero General Public License v3.0
78 stars 31 forks source link

icon for language selector #54

Closed patogit closed 3 years ago

patogit commented 6 years ago

Putting a language selector icon, like the one on www.wikipedia.org... but that one is in a sprite, and I can't find the file.

aparcar commented 6 years ago

Here is a icon set you might want to use.

aparcar commented 6 years ago

There is work happening on a chef rewrite in vuejs, please check this out and reopen the issue there: https://github.com/edvm/chef

patogit commented 6 years ago

There is work happening on a chef rewrite in vuejs, please check this out and reopen the issue there: https://github.com/edvm/chef

@aparcar GitHub does not allow me to open an issue in that repo.

the icon I want to add to the language selector is available in SVG and PNG: https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/resources/images/compact-links-trigger.svg https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/resources/images/compact-links-trigger.png

aparcar commented 6 years ago

There is work happening on a chef rewrite in vuejs, please check this out and reopen the issue there: https://github.com/edvm/chef

@aparcar GitHub does not allow me to open an issue in that repo. The devs seems to stopped development (for now), so no worries requesting it here.

the icon I want to add to the language selector is available in SVG and PNG: https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/resources/images/compact-links-trigger.svg https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/resources/images/compact-links-trigger.png

I don't fully understand, you want to add a single icon or a flag icon per language? In both cases please check the HTML code in chef.html

patogit commented 5 years ago

this is the image I want to add. I want it to appear to the left of the language selector menu, so I'm guessing there are two steps: put the image file in the repo, and then add a line after line 16 in chef.html that puts the image in the correct place with the correct alignment. (edit: since line numbers change in different branches: the language selector icon goes after the line <a class="navbar-brand" href="">Chef Imagebuilder <b>BETA</b> dev</a>)

patogit commented 5 years ago

What's the development branch? In other words, if I make the change required and make a pull request, what branch shall I send the request to?

aparcar commented 5 years ago

always master

aparcar commented 3 years ago

We got some icons for the language selector in the new interface.

Please open ASU specific issues here: https://github.com/aparcar/asu/ Please open interface specific issues here: https://gitlab.com/openwrt/web/firmware-selector-openwrt-org

Chef is no longer developed.