search

libremesh / lime-app

Geek-free Web App for setup and mantainance of Libremesh nodes built on Preact
https://libremesh.github.io/lime-app/
GNU Affero General Public License v3.0
50 stars 26 forks source link

Integrate FeaturePeek to be able to review storybook changes easier #257

Open nicopace opened 4 years ago

nicopace commented 4 years ago

If we integrate featurepeek we will be able to see how each PR looks like from the github interface without having to download and build the code, streamlining the review process.

nicopace commented 4 years ago

Here you can see a quick recap of what it enables: https://dashboard.featurepeek.com/peek/237hv52#/0

ilario commented 4 years ago

In lime-packages a similar thing is being done using Travis:

https://github.com/libremesh/lime-packages/blob/3e11bd142d9b7cbb58bd5bea6d0bac906484dcca/.travis.yml#L63-L65

in which each PR gets compiled and published on a server (which in the lime-packages case is https://snapshots.libremesh.org/branches which is not working).

germanferrero commented 3 years ago

@nicopace we tried it, but featurepeek requests permission over private repositories. Wich is too much for @spiccinini and me: Imagen Pegada el 2020-8-5 16-56

We are exploring own hosted solutions :)

nicopace commented 3 years ago

It looks like private repositories are optional... it is in yellow... isn't there any chance to disable that? (clicking on the yellow thingy)

spiccinini commented 3 years ago

Nope...

On Wed, Aug 5, 2020 at 6:34 PM Nicolás Pace notifications@github.com wrote:

It looks like private repositories are optional... it is in yellow... isn't there any chance to disable that? (clicking on the yellow thingy)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libremesh/lime-app/issues/257#issuecomment-669523904, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD2I2MEVCJHZRT7DXHVPXLR7HF4ZANCNFSM4NODQF7A .