search

libremesh / lime-app

Geek-free Web App for setup and mantainance of Libremesh nodes built on Preact
https://libremesh.github.io/lime-app/
GNU Affero General Public License v3.0
50 stars 27 forks source link

Add icons to menu #353

Closed luandro closed 1 year ago

luandro commented 1 year ago

During many implementations with communities with low-literacy levels, I missed having visual cues to point too where certain actions can be performed. So I've added some icons from teenyicons.com which can help with that.

image

selankon commented 1 year ago

I guess that react-icons package only bundle imported icons and not the full size library.

This could be a better solution than embed svg

On October 31, 2022 2:47:30 AM GMT+01:00, "Nicolás Pace" @.> wrote: @. commented on this pull request.

I like it! Not sure if embedding the svg is the best practice... will leave that to others that might know better than me :) (although it looks like one of the proposed approaches: https://www.bitovi.com/blog/best-practices-for-working-with-svgs ).

@@ -3,5 +3,8 @@ import { h } from 'preact'; import { Trans } from @.***/macro';

export const NetAdminMenu = () => (

Hi Luandro! Thanks for this... I would invite you to propose that change in another PR.

-- Reply to this email directly or view it on GitHub: https://github.com/libremesh/lime-app/pull/353#pullrequestreview-1161244625 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

germanferrero commented 1 year ago

Wow this svgs are really tiny (600bytes in avg each). Thanks @luandro