search

libremesh / lime-packages-ui

Set of packages for libremesh user interface
GNU Affero General Public License v3.0
6 stars 4 forks source link

use lime.config instead of raw uci #16

Open aparcar opened 6 years ago

aparcar commented 6 years ago

instead of using raw uci to get and set options we could simplify the code by using the lime config libary

gmarcos87 commented 6 years ago

That may be the right way to go. At https://github.com/libremesh/lime-packages-ui/blob/53cb8acfe663bd0f545ffa75788347e533bf92b3/packages/ubus-lime-utils/files/usr/libexec/rpcd/lime-utils#L179 I use that approach. It would be interesting to better resolve the use of lime-config, lime-apply and even safe-reboot when changing configurations.

p4u commented 6 years ago

I think what @aparcar means is to use the libremesh libraries such as config.lua

https://github.com/libremesh/lime-packages/blob/develop/packages/lime-system/files/usr/lib/lua/lime/config.lua

Instead of calling raw uci library for set/get values and other operations.