search

libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
276 stars 95 forks source link

Remove primary_interface unused option #1026

Closed ilario closed 1 year ago

ilario commented 1 year ago

In lime-defaults, there is a primary_interface option: https://github.com/libremesh/lime-packages/blob/396c37ac8b853156e8c72dd51cb387736f4dc05c/packages/lime-system/files/etc/config/lime-defaults#L19

But it is currently not being used: https://github.com/search?q=repo%3Alibremesh%2Flime-packages+primary_interface&type=code

So it should be removed for avoiding confusion.

spiccinini commented 1 year ago

It is used by primary_mac() that is used by primary_address() that is used in many places, or I am wrong?

ilario commented 1 year ago

Sorry, I trusted the search function of Github, so I completely missed its usage in primary_mac.