Closed javierbrk closed 9 months ago
Merging #1042 (1fa531b) into master (44043c1) will decrease coverage by
0.03%
. The diff coverage isn/a
.:exclamation: Current head 1fa531b differs from pull request most recent head 20e9dd3. Consider uploading reports for the commit 20e9dd3 to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 79.75% 79.73% -0.03%
==========================================
Files 53 53
Lines 4539 4539
==========================================
- Hits 3620 3619 -1
- Misses 919 920 +1
see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Hi! Two questions:
Yeah using libremesh.mk is in usually a good idea, anyway I have talked with @javierajorge and we concluded the two uci-defaults files that would be the only real addition from this package should instead be included in lime-app as the reference state stuff is all lime-app specific, so this PR will be closed once @javierbrk and @selankon include the contributed code in the proper package (lime-app os some of it's modules).
about upstreaming shared-state code to OpenWrt it is a good idea but not for now, ATM some parts of it like the neighbour candidate discovery does assumptions that are quite tied to libremesh network model even if it doesn't depends on it directly, so we would risk to upstream something that works badly on a different setup, I am working now on a new version of shared-stare that will be a more reasonable candidate for upstreaming to OpenWrt.
Cheers!
Here is an attempt to move the scripts into lime app package, what do you think ?
Here is an attempt to move the scripts into lime app package, what do you think ?
Seems fine to me, let's wait to hear @selankon if he thinks this is the proper place where to ship those uci-defaults
Network reference state will be defined by the UI. The data types must be supported and sync using shared state. This package provides two new data types one for WiFi links information and the other for nodes available in the network