search

libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
274 stars 94 forks source link

eupgrade: set cached_only to false #1070

Closed selankon closed 3 months ago

selankon commented 5 months ago

Fixes #1069

spiccinini commented 5 months ago

Did you try with the lime-app? Forcing no cache will slow the load of the app right @germanferrero ?

selankon commented 5 months ago

@spiccinini the react query that check for updates should not block the ui.

BTW, we could use a background process or something like that, to check the updates, and let this just set to false? I am not familiarized with OWRT systems, have they something similar to services?

G10h4ck commented 5 months ago

I would expect from a function named like that to not return a cached result. Do the sub-called function trigger the download? If this change slow down the UI, I would suggest to split triggering the download into another function

spiccinini commented 5 months ago

Do the sub-called function trigger the download?

AFAIK no. The issue is that until the http GET does not return it will block (and if you don't have internet it will timeout in more than a few seconds).

spiccinini commented 5 months ago

@spiccinini the react query that check for updates should not block the ui.

You mean that the current code does not block or that it should not? In some version of the lime-app it blocked the main page of the app, if you tested something like even adding a sleep(30) in the lua file does not block then good!.

ilario commented 3 months ago

This edit has been included by @selankon in #1101 so I would close this pull request. If you consider that the discussion was not finished and that the change should be reverted, please re-open this or open a new issue.