lime-app still uses $RANDOM in crontab

libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking

https://libremesh.org/

GNU Affero General Public License v3.0

274 stars 94 forks source link

lime-app still uses $RANDOM in crontab #1075

Open pony1k opened 5 months ago

pony1k commented 5 months ago

These two scripts add lines to crontab that use ash $RANDOM, which does not work in OpenWrt 19.07 to OpenWrt 22.03.

shared-state-reference_state_nodes_info_cron
shared-state-reference_state_wifi_links_info_cron

Are these cronjobs still needed? Should they be repaired?

ilario commented 3 months ago

I start thinking that we have to abandon OpenWrt 22 and previous ones, as shared-state-async is not possible to compile on them. And $RANDOM is available on OpenWrt 23 (https://github.com/libremesh/lime-packages/issues/800#issuecomment-1522950082) so we should eliminate random_numgen at some point and use only $RANDOM. Do you agree?

pony1k commented 3 months ago

I agree. I can see no reason to use OpenWrt 22 or earlier on new installations.