Closed javierbrk closed 8 months ago
Attention: Patch coverage is 87.50000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 79.64%. Comparing base (
63242c2
) to head (5336c53
). Report is 44 commits behind head on master.:exclamation: Current head 5336c53 differs from pull request most recent head 5356cbd. Consider uploading reports for the commit 5356cbd to get more accurate results
Files | Patch % | Lines |
---|---|---|
...s/lime-system/files/usr/lib/lua/lime/proto/lan.lua | 87.50% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request adds shrare-state-async ubus interface. Get method returns sharedstate "get" json data or reported error in case no json is found. Errors are bubbled up as they come from sharedstate inside a json structure with the name "error".
Since there is no Shared State async binary available in the testing environment, testing possibilities are reduced. Manual testing can be done on a router with bat-hosts package using this commands:
Get bat-hosts
Get an invalid data type
Sync valid data type
Sync invalid data type
Sync valid data type with unreachable ipv4 addresses
Sync valid data type with invalid ipv4 address
Sync invalid data type with specified ipv4 address
Sync valid data type with reachable ipv4 addresses