libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
274 stars 94 forks source link

Add shared-state-async network statistics sharing #1087

Closed G10h4ck closed 4 months ago

ilario commented 4 months ago

We should keep compatibility (or at least avoid breaking it explicitly) with OpenWrt 21 at least until we make a release based on OpenWrt 23, in my opinion. Please use random_numgen instead of $RANDOM. See https://github.com/libremesh/lime-packages/issues/800

-- Inviato dal mio smartstone

G10h4ck commented 4 months ago

This stuff (and in general what is meant for mesh-wide milestone) is developed on top (and depends) on OpenWrt development branch, as an example shared-state-async depends on a GCC version which is not shipped yet in OpenWrt stable releases, otherwise it will not compile properly. So doing the change you suggests hoping for retro-compatibility would be futile.

G10h4ck commented 4 months ago

other even more retro-compatibility breaking stuff is coming to out of my experimentation to have better support for newer radios https://www.youtube.com/live/DOH5FBMTXmE?feature=shared&t=10848

ilario commented 4 months ago

Ok, will it work at least on OpenWrt 23? If not, please do not propose those changes on the master branch, which is being used for preparing a release based on OpenWrt 23 (we could also create a branch for the release...).

G10h4ck commented 4 months ago

AFAIU it will not work on OpenWrt 23 either, @javierbrk tried to compile and failed because of not enough recent compiler AFAIR

Better creating a branch for the planned release and backport there stuff if needed, while development keep staying on master branch

ilario commented 4 months ago

Ok, please create a branch with the code you know will work with OpenWrt 23.

G10h4ck commented 4 months ago

Ain't got time for that last compatible commit should be this https://github.com/libremesh/lime-packages/commit/a5eb7d888b681e4cab81289949d809ee0e968880

pony1k commented 4 months ago

AFAIU it will not work on OpenWrt 23 either, @javierbrk tried to compile and failed because of not enough recent compiler AFAIR

I compiled shared-state-async from a823f4727e14297d1c8d7a07cdee18ef26246fb1 for OpenWrt 23.05.2 and it is working.

javierbrk commented 4 months ago

Hi ! My compilation errors were using gcc 11 shipped with openwrt 22.03 !

Saludos Ing. Javier Alejandro Jorge

On Mon, 26 Feb 2024 at 14:24, pony1k @.***> wrote:

AFAIU it will not work on OpenWrt 23 either, @javierbrk https://github.com/javierbrk tried to compile and failed because of not enough recent compiler AFAIR

I compiled shared-state-async from a823f47 https://github.com/libremesh/lime-packages/commit/a823f4727e14297d1c8d7a07cdee18ef26246fb1 for OpenWrt 23.05.2 and it is working.

— Reply to this email directly, view it on GitHub https://github.com/libremesh/lime-packages/pull/1087#issuecomment-1964702462, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE2I2CH4VND7XYCKFWIRD3YVTAN5AVCNFSM6AAAAABDUTR45CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUG4YDENBWGI . You are receiving this because you were mentioned.Message ID: @.***>

G10h4ck commented 4 months ago

Good news! So we can go ahead without dealing with multiple branches for now