libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
281 stars 96 forks source link

bat_hosts: fixes rpcd error #1094

Closed javierbrk closed 8 months ago

javierbrk commented 8 months ago

Rpcd get bat hosts call was not working causing lime app UI to fail when trying to retrieve host names.

This pull request fixes the rpc call.

the function "bat_hosts.get_bat_hosts_from_shared_state()" was created for testing purposes.

 ubus call bat-hosts get_bathost '{"mac":"AE:40:41:1C:85:16"}'
{
        "status": "ok",
        "bathost": {
                "iface": "wlan1-mesh_17",
                "hostname": "LiMe-8037b1"
        }
}
codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.79%. Comparing base (069ac1a) to head (29822ca).

:exclamation: Current head 29822ca differs from pull request most recent head d7a3873. Consider uploading reports for the commit d7a3873 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1094 +/- ## ========================================== + Coverage 79.69% 79.79% +0.10% ========================================== Files 53 53 Lines 4576 4574 -2 ========================================== + Hits 3647 3650 +3 + Misses 929 924 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

G10h4ck commented 8 months ago

shouldn't lime-app ported to shared-state-async ubus interface instead? so we can drop this plugin altogether?

javierbrk commented 8 months ago

this is just a quick fix to #1093 It will bring consistency to the limeapp version linked in the repository. I think that the other alternative requires a new release of the lime app.