search

libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
274 stars 94 forks source link

safe-upgrade: update calibration data partition name #1098

Closed G10h4ck closed 2 months ago

G10h4ck commented 3 months ago

DISCLAIMER: Breaks safe-upgrade retrocompatibility!

Newer OpenWrt rely on calibration data MTD partitions being named 'art' older OpenWrt on which librerouterOS 1.5 is based, looked for calibration calibration data for on-SoC radio on 'ART' partition. In particular librerouter v1 have an on SoC radio which have calibration data in art partition, safe-upgrade can either support older OpenWrt version or newer, but not both at least without change the code drastically. Here in development branch let's support new OpenWrt.

spiccinini commented 3 months ago

When I hardcoded the partiions name years ago I tought that if the partitions name changed then they should come with the upgrade file so that it is not hardcoded here. So maybe sesrching for a specific env variable or file somewhere and use that or default to the hardcoded values is valuable?

G10h4ck commented 3 months ago

One of the big problems is that such environments variables or config files where we could get such information, differ between the running system (the one where safe-upgrade is executed) and the image one is going to flash, so the running safe-upgrade is the old one in the old image and can access the information in the old image, while we would need the information stored in the new image, unless we mount the new image and look into it do discover such information we cannot de-hardcode the info.

spiccinini commented 3 months ago

eupgrade supports an installer type that we used in the past to provide this kind of upgrades. The installer is just a .sh script that can also contain the image binary. I created this tool https://github.com/spiccinini/shellbinscript that embeds files inside the installer.sh script. In that way we provided a new safe-upgrade to not rely in the one already installed. In this repo there are some install scripts we used in the past: https://gitlab.com/librerouter/lros-installersh-scripts/-/tree/v1.5?ref_type=heads

So the idea can to just use the installer type, providing the bootargs alongside the image. Other idea is to put the bootargs as metadata of the image (the image currently has the board name as metadata)

ilario commented 2 months ago

Should we pick this to the 2024.1 branch? Is this good or bad for the next release candidate?

G10h4ck commented 2 months ago

@ilario this is needed if you plan to use safe-upgrade with librerouter v1 devices based on OpenWrt current release

ilario commented 2 months ago

So I understand that yes, it should be included in the next release candidate. Thanks