libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
280 stars 96 forks source link

lime-apply: remove it or update it #352

Open aparcar opened 6 years ago

aparcar commented 6 years ago

If watchping isn't installed the following error appears:


root@meshrc-73724b:~# lime-apply
Apply hostname
Reload network config
Reload routing protocols
Failed to parse json data: unexpected character
/usr/bin/lime-apply: line 34: /etc/init.d/watchping: not found
/usr/bin/lime-apply: line 34: /etc/init.d/watchping: not found```
aparcar commented 6 years ago

@p4u @axn

Is this workaround still required or can we completely remove it? https://github.com/libremesh/lime-packages/blob/master/packages/lime-system/files/usr/bin/lime-apply#L15

On bmx7 it seems to change and distribute the hostname even without a restarting/reloading bmx7 nor running lime-config

aparcar commented 6 years ago

@axn ping?

dangowrt commented 6 years ago

On bmx7 it seems to change and distribute the hostname even without a restarting/reloading bmx7 nor running lime-config

Yes, because procd is handling the reloads...

aparcar commented 6 years ago

@dangowrt yes as in "it can be removed"?

aparcar commented 6 years ago

@dangowrt ping

dangowrt commented 6 years ago

To my understanding lime-apply is a work-around from pre-procd times. Nowadays services can define reload-triggers and get signalled on configuration changes automatically. Imho lime-apply can be dropped as a whole, I never used it and I'm not aware of any use-cases where a work-around like that would be required. Anyone else?

aparcar commented 6 years ago

@dangowrt so Alfred lacks procd support but that should be easy to fix.

Lime apply runs a network reload, so that may be the only thing to run manually, as bmx + Alfred + watching could be reloaded via procd

aparcar commented 6 years ago

related https://github.com/openwrt-routing/packages/issues/388

aparcar commented 6 years ago

related https://github.com/openwrt-routing/packages/pull/389

aparcar commented 5 years ago

@p4u @ilario looks to me as if we can remove lime-apply now

ilario commented 5 years ago

I never used lime-apply... Can we confirm that all its features are now achieved in another way or completely unneeded?

aparcar commented 5 years ago

@p4u @dangowrt you know of a better way to "apply" the hostname?

p4u commented 5 years ago

Why would u remove it? As there is a lime-config I think it makes sense to have a lime-apply. I'm using it (via terminal) and webui uses it too.

In addition there are some extra tasks which are not covered by a reload_config or network reliad commans (such as the hostname).

El 14 de gener de 2019 16:08:47 CET, Paul Spooren notifications@github.com ha escrit:

@p4u @dangowrt you know of a better way to "apply" the hostname?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/libremesh/lime-packages/issues/352#issuecomment-454037184

-- Enviat des del meu dispositiu Android amb el K-9 Mail. Disculpeu la brevetat.

ilario commented 5 years ago

Update (reading comments above, seems that alfred and bmx* stuff is not needed anymore, we can delete that. And we should check if stuff is missing) or drop (just rebooting for applying the new configuration)?

spiccinini commented 5 years ago

I would not label this issue nor easy nor good first issue until we have consensus about what has to be done. What we know is that lime-apply is not 100% reliable because some things need a reboot (like changing the country code).

aparcar commented 5 years ago

so let's reboot things to be sure. Remove the tool and adopt the documentation to tell users to reboot after configuration

nicopace commented 5 years ago

We shouldn't reboot unless is extremely necesary, the neighbours rely on the infrastructure and we shouldn't asume reboot is harmless in a working network. We can flag which configs need reboot, and suggest it. For now, those that we have detected are:

what else?