search

libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
276 stars 96 forks source link

New network name created via FBW is forced to lowercase but default is mixed case #659

Open ilario opened 4 years ago

ilario commented 4 years ago

FirstBootWizard forces the users to use lowercase names for the new networks (see https://github.com/libremesh/lime-app/commit/73d464e) but the default "LibreMesh.org" is not lowercase.

The lowercase was introduced as a bug fix (mentioned here) but the bug is not specified, maybe is for avoiding confusion?

We should change the default "LibreMesh.org" to "libremesh.org". A (maybe small but surely annoying for someone) drawback is that the 10.13.x.x network domain would change to 10.249.x.x

ilario commented 3 years ago

Fixed with https://github.com/libremesh/lime-app/pull/268

ilario commented 3 years ago

Maybe this is not 100% fixed, see https://github.com/libremesh/lime-app/issues/288

germanferrero commented 3 years ago

Oh, no my fault, we do want hostnames to be lower case forced. I though we didn't. Network names are note forced to be upper-case. Thanks @ilario

ilario commented 3 years ago

Mh... Let's keep the "hostname" and "network name" issues clearly separated please, I am a bit confused now.

Problem 1: Network name defaults to "LibreMesh" (in lime-system's lime-defaults) but the fbw (and lime-app?) forces it to be lowercase. Is this correct?

Problem 2: Hostname defaults to LiMe-%M4%M5%M6 but fbw (and lime-app?) forces it to lower case. Is this correct?

germanferrero commented 3 years ago

Problem 1: Network name defaults to "LibreMesh" (in lime-system's lime-defaults) but the fbw (and lime-app?) forces it to be lowercase. Is this correct?

Not anymore, this was fixed by https://github.com/libremesh/lime-app/pull/268, now network name can use uppercase.

Problem 2: Hostname defaults to LiMe-%M4%M5%M6 but fbw (and lime-app?) forces it to lower case. Is this correct?

Yes, we have closed https://github.com/libremesh/lime-app/issues/210 to soon. @spiccinini said there:

We should allow uppercase network names. Hostnames, in my opinion, in lowercase. @germanferrero ?

I didn't answer then, now I do: I think we should allow uppercase on hostnames too. It gives more freedom to the users and it is harmless. DNS resolution is case insensitive.

spiccinini commented 3 years ago

We should allow uppercase network names. Hostnames, in my opinion, in lowercase. @germanferrero ?

I didn't answer then, now I do: I think we should allow uppercase on hostnames too. It gives more freedom to the users and it is harmless. DNS resolution is case insensitive.

I think it is better to use all lowercase hostnames, and change the default to lime-%M4%M5%M6, because there is a lot of broken software in the world that does not have case insensitivity support. I know that enforcing softly the all lowercase hostname is not a proper fix, and bugs may pile under the carpet (for example storing hostnames in hash maps without prior enforcing lowercase, etc). In the other hand I think it is more confusing to have mixed case hostnames.

ilario commented 1 year ago

So it would be enough to change this line:

https://github.com/libremesh/lime-packages/blob/78162b4d773c9e8d01f63801ce3464ea84ac89b6/packages/lime-system/files/etc/config/lime-defaults#L9