search

libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
276 stars 96 forks source link

Shared state publishing twice babeld_hosts and bat_hosts on boot #862

Open germanferrero opened 3 years ago

germanferrero commented 3 years ago

Both: babeld_hosts at: https://github.com/libremesh/lime-packages/blob/aa55eb84d8c02d7b23949ccc24f1b7c030d63daa/packages/shared-state-babeld_hosts/files/etc/hotplug.d/initd/shared-state-babeld_hosts#L6

and bat_hosts at: https://github.com/libremesh/lime-packages/blob/aa55eb84d8c02d7b23949ccc24f1b7c030d63daa/packages/shared-state-bat_hosts/files/etc/hotplug.d/iface/shared-state-bat_hosts.sh#L2

Are scheduled to publish on boot (and interface up).

And also at: https://github.com/libremesh/lime-packages/blob/aa55eb84d8c02d7b23949ccc24f1b7c030d63daa/packages/shared-state/files/etc/init.d/shared-state#L6 Shared State schedules all publishers to publish on boot, so we are doing it twice for these two, overloading the boot process.

predators46 commented 3 years ago

No found tmate

https://github.com/libremesh/lime-packages/blob/aa55eb84d8c02d7b23949ccc24f1b7c030d63daa/packages/ubus-tmate/Makefile#L16

ilario commented 1 year ago

So, which is ok to remove? @spiccinini do you have idea? It would be easier to remove the hotplug.d.

ilario commented 1 year ago

We should not remove the one in /etc/init.d, see https://github.com/libremesh/lime-packages/pull/1004#issuecomment-1508090185