search

libremesh / lime-packages

LibreMesh packages configuring OpenWrt for wireless mesh networking
https://libremesh.org/
GNU Affero General Public License v3.0
281 stars 96 forks source link

ubus-lime-utils uses watchping but does not depend on it and should check for client-wwan before running #956

Open ilario opened 1 year ago

ilario commented 1 year ago

As commented here https://github.com/libremesh/lime-packages/issues/927#issuecomment-1331084524 the ubus-lime-utils package uses watchping here: https://github.com/libremesh/lime-packages/blob/400ac95448a1f1d5a83496488e40c302cde766f0/packages/ubus-lime-utils/files/etc/udhcpc.user#L11

but it does not include it in its dependencies. This results in the following error:

/usr/share/udhcpc/default.script: /etc/udhcpc.user.d/50-client-wwan-watchping: line 11: /etc/init.d/watchping: not found

Additionally, if udhcpc is run manually, it also complains about the nonexistence of client-wwan interface:

ip: can't find device 'client-wwan'

so that a check should be included for the existence of the interface before proceeding.

ilario commented 2 weeks ago

Additionally, if udhcpc is run manually, it also complains about the nonexistence of client-wwan interface:

ip: can't find device 'client-wwan'

so that a check should be included for the existence of the interface before proceeding.

The if check should be inserted between these two lines: https://github.com/libremesh/lime-packages/blob/08a3948a5a80f6e26318c96227e02466bd09345e/packages/ubus-lime-utils/files/etc/udhcpc.user.d/50-client-wwan-watchping#L2-L3

ilario commented 2 weeks ago

@spiccinini you are indicated as the maintainer of this package, are you still interested in maintaining it? Can you fix this issue?