search

libremesh / lime-sdk

LibreMesh software development kit
http://libremesh.org/
GNU General Public License v3.0
50 stars 36 forks source link

--update-feeds by default? #31

Closed ilario closed 5 years ago

ilario commented 6 years ago

In my opinion cooker should update the feeds (--update-feeds) by default, and having a --no-update-feeds required for avoiding this. This would limit situations where users compile broken formware like here.

aparcar commented 6 years ago

Sound good.

p4u commented 6 years ago

Agree

nicopace commented 6 years ago

I would say it would be relevant to tell the user that there are updates that can be done, but not enforce by default to update. It is an undesired sideeffect if you want to have reproducible builds, as each time you run build you may get different packages without the parameters changing in your commandline. I would propose for the system to do a non-destructive action of checking if there were changes that could be applied by fetching but not merging the remote changes. It is as easy as doing fetch on each git repo, and showing how many commits are from the previous to the current situation.

G10h4ck commented 5 years ago

The reproducibility of the builds is guaranted for releases anyway because of tags used for repository feeds, but having to specify manually to update the feeds is quite antipattern in almost any case, so I would merge the related pullrequest

nicopace commented 5 years ago

Like the approach... will review the code now.

nicopace commented 5 years ago

jej, thought it was a PR... like the approach proposed by @G10h4ck

ilario commented 5 years ago

Fixed by #70