search

libremesh / lime-sdk

LibreMesh software development kit
http://libremesh.org/
GNU General Public License v3.0
50 stars 36 forks source link

Changes to Docker instructions in Readme #43

Closed ilario closed 6 years ago

ilario commented 6 years ago

For me the current version of the command in the readme didn't work, this works. Can anyone confirm? And the -it option doesn't seem to be needed.

nicopace commented 6 years ago

This is what -it does:

       -i, --interactive=true|false
          Keep STDIN open even if not attached. The default is false.

       When set to true, keep stdin open even if not attached. The default is false.

       -t, --tty=true|false
          Allocate a pseudo-TTY. The default is false.

       When set to true Docker can allocate a pseudo-tty and attach to the standard input of any container. This can be used, for example, to run a throwaway interactive shell. The default is false.

       The -t option is incompatible with a redirection of the docker client standard input.
ilario commented 6 years ago

Thanks. So it's not needed for current version of cooker, do you agree? @nicopace

nicopace commented 6 years ago

Without -i you wll not have an interactive console... ie, not able to run bash. if you run cooker directly, then it is not needed.

Don't know about -t.

ilario commented 6 years ago

I just realized a thing where -it is really useful: Ctrl + C for interrupting easily the compilation.

nicopace commented 6 years ago

I just realized a thing where -it is really useful: Ctrl + C for interrupting easily the compilation.

Should we revert then?

ilario commented 6 years ago

Should we revert then?

Nope, sorry, in this PR there were three changes and removing -it was just one of them. I'll do another PR...