search

libremesh / lime-sdk

LibreMesh software development kit
http://libremesh.org/
GNU General Public License v3.0
50 stars 36 forks source link

Add support for feeds.conf src options #50

Closed nicopace closed 6 years ago

nicopace commented 6 years ago

In https://wiki.openwrt.org/doc/devel/feeds openwrt sdk and ib support multiple feed fetching methods. Giving support to at list src-link or src-spy will allow to have local repositories integrated within lime-sdk.

p4u commented 6 years ago

This is already possible be adding your own feeds in feeds.conf.default

There is a documentation about how to use your own feed in the README file of lime-sdk

nicopace commented 6 years ago

I tried it a few days ago and src-link and src-cpy where not working. When I changed them to src-git it started working.

Could it be because it is not implemented here? https://github.com/libremesh/lime-sdk/blob/master/cooker#L280

p4u commented 6 years ago

Ok, now I understand the issue.

And yes, it probably needs some changes in the code. However you can always use git in a local directory

Example of what I'm saying:

mkdir feed1 cd feed1 git init cd .. git clone ./feed1 feed2

At this point feed2 is a clone of feed1 and the remote is a local directory file.

On 09/01/18 17:21, Nicolás Pace wrote:

I tried it a few days ago and src-link and src-cpy where not working. When I changed them to src-git it started working.

Could it be because it is not implemented here? https://github.com/libremesh/lime-sdk/blob/master/cooker#L280

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/libremesh/lime-sdk/issues/50#issuecomment-356334198, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBo9g7peajipxh5QvuYMW6bkZGwwlatks5tI5H2gaJpZM4RW4gL.

nicopace commented 6 years ago

Yes, I was doing that... just wanted to state that it in order to comply with how openwrt defines the feeds.conf, there was some lacking. Not difficult dough'... could be left as an exercise for someone starting with lime-sdk :)

p4u commented 6 years ago

Ok, agreed.

Right now cooker ignores the non-git feeds https://github.com/libremesh/lime-sdk/blob/master/cooker#L280

That may be changed to support also more kind of feeds.

nicopace commented 6 years ago

This shouldn't be closed, as it is still a pending and useful feature. Reopening it.

aparcar commented 6 years ago

@nicopace please review PR

aparcar commented 6 years ago

fixed