Closed wfleurant closed 6 years ago
Thanks for the contributions. For what I can understand this is going to get the sources and outputs out of the docker context... but then, where are they going to exist? Is there any update on the README needed for this?
thanks!
Hi Nico, the context of /app in the base cooker image should exclude cooker artifacts. I guess the case I hit is where/when Dockerfile updated but the latest cooker tag was built using a dirty lime-sdk git tree.
The .dockerignore should apply to first example below and found in README.
What if .dockerignore was just made a symbolic link to .gitignore?
docker build -t cooker .
docker run -v "$(pwd)":/app cooker --\<parameters>
its easy to avoid this
Did you dealt with it in another way? Can we document it?
Thanks
On October 7, 2018 8:55:02 PM MDT, William Fleurant notifications@github.com wrote:
Hi Nico, the context of /app in the base cooker image should exclude cooker artifacts. I guess the case I hit is where/when Dockerfile updated but the latest cooker tag was built using a dirty lime-sdk git tree.
The .dockerignore should apply to first example below and found in README.
What if .dockerignore was just made a symbolic link to .gitignore?
Build 'cooker' base image from Dockerfile (command adds $PWD to
/app (excluding lime-sdk outputs))
docker build -t cooker .
Cooks something (command overrules base image /app (mounts $PWD
in 'cooker'))
docker run -v "$(pwd)":/app cooker --\<parameters>
-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/libremesh/lime-sdk/pull/89#issuecomment-427710808
-- Enviado desde mi dispositivo Android con K-9 Mail. Por favor, disculpa mi brevedad.
docker build context
before
after