Added some changes from Rob Collins and make the thing more happy with php 7.4

librenms-plugins / Weathermap

MIT License

64 stars 51 forks source link

Added some changes from Rob Collins and make the thing more happy with php 7.4 #67

Closed xbeaudouin closed 1 year ago

xbeaudouin commented 3 years ago

Added commits from Rob Collins wich are nice code. See https://github.com/RobsanInc/Weathermap Fix several warnings about deprecated code on PHP 7.4...

calinrigo commented 3 years ago

Seems like after the latest PHP dependency update for LibreNMS, the weathemap plugin is not working anymore. I get "PHP Deprecated: The each() function is deprecated" when cron tries to create the output files using the php command.

I see the merge contains some fixes that should fix this issues I'm having also.

Is it possible to merge them?

lutfisan commented 3 years ago

why this pull request does not merge yet?