search

librenms-plugins / Weathermap

MIT License
64 stars 51 forks source link

Fix rrdcached support #75

Closed vliberio closed 2 years ago

vliberio commented 2 years ago

rrdcached support was broken in 8955b99ac7d31581e2fb0e7d037311a9fb3389a8 removing the addition of the --daemon option to the rrdtool command. This simply adds the daemon argument in lib/datasources/WeatherMapDataSource_rrd.php, if set in weathermap.php, allowing this plugin to correctly function with rrdcached.

mgradowskiempik commented 2 years ago

Hello

I would like to reopen this issue.

After recent changes, 8955b99, 64c38d51, path passed to rrdtool fetch is absolute. Examples, before: cd /opt/librenms/rrd; /usr/bin/rrdtool fetch --daemon 127.0.0.1:11212 10.10.1.2/port-id42.rrd AVERAGE --start now-800 --end now after: /usr/bin/rrdtool fetch /opt/librenms/rrd/10.10.1.2/port-id42.rrd AVERAGE --start now-800 --end now --daemon 127.0.0.1:11212

rrdcached doesn't support this:

$ /usr/bin/rrdtool fetch /opt/librenms/rrd/10.10.1.2/port-id42.rrd AVERAGE --start now-800 --end now --daemon 127.0.0.1:11212
ERROR: absolute path names not allowed when talking to a remote daemon