Update init checks to be less restrictive

librenms / docker

LibreNMS Docker image

MIT License

692 stars 280 forks source link

Update init checks to be less restrictive #347

Closed duhow closed 2 days ago

duhow commented 1 year ago

As of https://github.com/librenms/docker/pull/283 restrictive check, Docker images after 22.6.0 are not working properly for us.

We are running LibreNMS in Kubernetes, where we have the config.php mounted as ConfigMap (read-only for the file system), and also Redis has disabled FLUSHDB as a safety measure.

Changes applied in here:

Ignore errors if cannot clean config.d folder initially.
Create new config.d files only if folder is writable.
Update chown folders only if are writtable.
Ignore if cache:clear fails. (Redis)

murrant commented 1 year ago

Question, how do you clear possibly incompatible cached data from redis?

duhow commented 1 year ago

I haven't had the "need", but from the current test 22.6 to 23.4 I didn't find any "incompatible issues". @murrant Would it help to show a warning message but continue running the software?

duhow commented 1 year ago

@crazy-max can you review changes again and validate?

LoveSkylark commented 1 month ago

I struggled with this Kubernetes + config.php and ultimately I solved this using lnms instead: https://github.com/LoveSkylark/LibreNMS-Helm/blob/main/templates/jobs-install.yaml

murrant commented 2 days ago

@LoveSkylark there is a way to do that without running lnms, any reason not to use it?

https://github.com/librenms/docker/blob/master/README.md#initial-configuration