search

librenms / docker

LibreNMS Docker image
MIT License
692 stars 280 forks source link

Set SNMP Trap Handler DIRs via librenms.env #354

Closed hjcday closed 1 year ago

hjcday commented 1 year ago

Changes to allow SNMP Trap MIB directories to be set via Env Variables instead of hard coded "/opt/librenms/mibs:/opt/librenms/mibs/cisco"

hjcday commented 1 year ago

@crazy-max should be good to go now

hjcday commented 1 year ago

Please squash your commits, otherwise LGTM.

I hope this is done correctly..

crazy-max commented 1 year ago

Please squash your commits, otherwise LGTM.

I hope this is done correctly..

There is still unrelated changes like https://github.com/librenms/docker/pull/354/commits/21836147075cfb3074dea607a9caa681dbf6965b. The merge commit looks to be the issue, there should be a single commit when squashed: https://github.com/librenms/docker/pull/354/commits