search

librenms / librenms-agent

LibreNMS Agent & Scripts
GNU General Public License v2.0
118 stars 188 forks source link

Minor script reverts (osupdate, phpfpm) #362

Closed jepke closed 3 years ago

jepke commented 3 years ago

I needed to revert those changes to get the proper output which is handled by Librenms

I don't have any other then debian to test. But have more apps to add and test.

jepke commented 3 years ago

Kinda expected linter to complain about this lol

Jellyfrog commented 3 years ago

@jepke need to fix the failing test before we can merge

jepke commented 3 years ago

@Jellyfrog this fixes the SNMP extend scripts that broke in #355 and #356 i honestly have no idea how to fix the lint issues all i know is that when i reverted the changes made last week all that i use work again.

I was able to test apt-get and yum for the osupdate script both broke when you applied the linter fixes in 355 and 356. I think its broken for the rest as well but unable to test.