search

librenms / librenms-agent

LibreNMS Agent & Scripts
GNU General Public License v2.0
116 stars 187 forks source link

Cleaning up certificate.py code and adding cert_location #447

Closed bnerickson closed 1 year ago

bnerickson commented 1 year ago

This looks like a large change, but it's really just code cleanup and the addition of a new feature (cert_location) to support self-signed certificates. First, the code cleanup:

I replaced the "e" variable with "err" for some pylint fixing. The global tasks have been placed into a main function as better code practice. Everything was run through vercel after the fact for code formatting.

Next, the cert_location feature is an optional addition to the certificate.json file that specifies the full path to the certificate for the domain/fqdn that is being validated. This is necessary for self-signed certificates.

bnerickson commented 1 year ago

Documentation update PR: https://github.com/librenms/librenms/pull/14721