search

librenms / librenms-agent

LibreNMS Agent & Scripts
GNU General Public License v2.0
117 stars 188 forks source link

Fix osupdate script broken by #444 #466

Closed jepke closed 1 year ago

jepke commented 1 year ago

444 broke osupdate script through snmp extend

JamesMenetrey commented 1 year ago

Hello,

While I'm unsure this is the right approach to fix this issue, I confirm this patch solves an issue where LibreNMS cannot pull the number of updates properly.

@VVelox This would be cool if you could look into it, as in the current state, the osupdate does not work.

Cheers!

VVelox commented 1 year ago

@JamesMenetrey Sure! Looking.

VVelox commented 1 year ago

Confirmed. This only works with the older extend with out that line. The LibreNMS commit in relationship to this only passed as there are no relevant tests to make sure it did not fail.

VVelox commented 1 year ago

Added a line to uncomment to use it as a agent. https://github.com/librenms/librenms-agent/pull/471

JamesMenetrey commented 1 year ago

Many thanks for your quick feedback!