librenms / librenms

Community-based GPL-licensed network monitoring system
https://www.librenms.org
Other
3.62k stars 2.22k forks source link

Add support for snmpsim-lextudio #16161

Closed freddy36 closed 3 days ago

freddy36 commented 6 days ago

Ilya Etingof, the author of the original snmpsim/pysnmp projects passed away on 10-Aug-2022. His snmpsim version doesn't work anymore with the current python version (3.12). This adds compatibility for the https://github.com/lextudio/snmpsim fork, which works with python 3.12.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926 After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

freddy36 commented 6 days ago

~~Please note that the current PyPI release (1.1.0) contains a bug which breaks compatibility with librenms. The fix (https://github.com/lextudio/snmpsim/pull/2) is already merged and should make it into the next release.~~ Version 1.1.1 has been released.

murrant commented 5 days ago

Thanks @freddy36 are these the only changes needed?

freddy36 commented 5 days ago

It works for me with these changes. I'm not sure how I installed it in the first place.