librenms / librenms

Community-based GPL-licensed network monitoring system
https://www.librenms.org
Other
3.95k stars 2.31k forks source link

Attempt to fix legacy email alerts #16730

Closed murrant closed 6 days ago

murrant commented 1 week ago

If you were affected by this bug, migrate to alert mail transport(s).

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926 After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

ervin09 commented 6 days ago

./scripts/github-apply 16730 Checking patch LibreNMS/Alert/RunAlerts.php... Checking patch LibreNMS/Alert/Transport/Mail.php... Checking patch LibreNMS/Util/Mail.php... Applied patch LibreNMS/Alert/RunAlerts.php cleanly. Applied patch LibreNMS/Alert/Transport/Mail.php cleanly. Applied patch LibreNMS/Util/Mail.php cleanly.

INFO Clearing cached bootstrap files.

events .................................................................................................................................. 5ms DONE views .................................................................................................................................. 14ms DONE cache ................................................................................................................................... 6ms DONE route ................................................................................................................................... 0ms DONE config .................................................................................................................................. 0ms DONE compiled ................................................................................................................................ 0ms DONE

so far looks good on my end. after applying the above , i don't see the error again.

thanks @murrant

ervin09 commented 6 days ago

image as mentioned above. no sign of that error any more , after applying the PR.

librenms-bot commented 5 days ago

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/24-11-0-changelog/26568/1