search

libreobjet / libreobjet.github.io

:package: As a group of industrial and graphic designers, hackers and artists, gathered together under the name Libre Objet, we all share a common question about open source industrial design, processes and products resulting from our work, with the aim of providing tools for accessing a free philosophy applied to the manufacture of objects.
http://libreobjet.org/
Other
31 stars 4 forks source link

Ignore license files (.txt) #10

Closed raphaelbastide closed 8 years ago

raphaelbastide commented 10 years ago

Stacey reads this txt file as a content file, we don’t want that. I assume we can deny access to all “license.txt” files in .htaccess right?

raphaelbastide commented 10 years ago

The issue can be found when the search page request results from parsing the 1.objects folder http://libreobjet.org/dev/search?q=Mathieu%20Gabiot

xuv commented 10 years ago

It's a basic default behavior of Stacey to read text files (and turn them into html pages). I don't know yet how to prevent reading that one, exspecially. Might be possible I guess. Will check.

raphaelbastide commented 10 years ago

Yes I can ignore it locally using permissions, but it doesn’t work on the server.

xuv commented 10 years ago

And if you just set up a empty license.html template? Would this solve it?

raphaelbastide commented 10 years ago

I don’t get it. How?

xuv commented 10 years ago

If we create an empty license.html fie in templates/ folder.

raphaelbastide commented 10 years ago

And then remove each lecense.txt on the project’s directory? The idea is to keep a license file in each project’s folder right? I don’t think creating a template for licenses will change something. Or I still don’t get it :)

xuv commented 10 years ago

No, don't remove them from the folders. But you said "Stacey reads this txt file as a content file, we don’t want that." So I thought, if we give it an empty template file, it will read the license.txt file but not do anything with it. Right?

xuv commented 10 years ago

If that doesn't work, we might have to patch stacey in the core so it doesn't read files named "license.txt"

raphaelbastide commented 10 years ago

Maybe we should hide the search link in the menu and unlink the object’s meta until we find a workaround.

tasinttttttt commented 10 years ago

Then you would have to disable the links to authors, clients etc. in the project detail view. Because they seem to be "search" links...

raphaelbastide commented 10 years ago

Yes they are, and they are supposed to be so. Fix in progress.

raphaelbastide commented 10 years ago

Temporary fix: licenses files doesn’t have txt extention anymore eg. license. This fixes our issue, search pages are now working online. This fix should remain temporary: only the online version of the objects are fixed this way, licenses in the repo still have the .txt extension. I leave the issue open.

This can be what we need to patch for a possible stacey core fix: https://github.com/libreobjet/libreobjet.org/blob/master/app/page-data.inc.php#L218

xuv commented 8 years ago

Issue not relevant anymore since the switch to Jekyll. *.txt files are not atken into account.