Open alexanderfefelov opened 3 years ago
Sorry for the late reply, I've been held up by work lately.
I agree that the data types aren't quite accurate, but I'm not really sure that I'd want to implement this change now, because:
I'll leave it open for now, but implementing this change is very unlikely in the near future. Maybe in v2?
Ping and co generates numerical data by nature. Using numerical data allows the LibreSpeed database to be treated as a time series database without any additional coding.
Yes, I understand, but in the code:
... fields in schema.TelemetryData
are all string
s. If this change is to be implemented, users with old schemas will not be able to insert/load records, unless they recreate the database. This would qualify as a breaking change.
This might be fixed with a migration: the code can detect this change at runtime and ask the user to migrate (or automatically migrate)
dl
,ul
,ping
,jitter
are numbers, not a text,text
andlongtext
are too big data types,Environment
Links