search

librespeed / speedtest-go

Go backend for LibreSpeed
GNU Lesser General Public License v3.0
733 stars 157 forks source link

Docker hub image publishing #43

Open Beanow opened 2 years ago

Beanow commented 2 years ago

Description

Automatically publishing images, ideally using the same librespeed/speedtest-go naming allows an easy 'straight from the source' install. Some CI, like GH actions makes this pretty easy. Especially when you're already maintaining a Dockerfile.

Why it should be implemented

I believe, https://hub.docker.com/r/mickkael/librespeed-go is the closest to an "official" image being published? It's a bit of a mess of people building their own speedtest-go/librespeed-go images. And the mickkael/librespeed-go one seems out of date, rocking v1.1.3, so I assume it is being pushed manually from a dev machine.

For reference a modern multi-arch GH action might look something like this. https://github.com/thomseddon/traefik-forward-auth/pull/275

masx200 commented 2 years ago

https://hub.docker.com/r/chishin/speedtest-go-zh

Beanow commented 2 years ago

:point_up: :warning: PSA be careful running random code you've not reviewed and have about 10 downloads image

It should prove my point why it'd be great to have an up-to-date official image:

It's a bit of a mess of people building their own speedtest-go/librespeed-go images.

mickkael commented 2 years ago

Let me make a GH action workflow to publish directly on this github registry. I'll get a Pull request

onedr0p commented 1 year ago

@mickkael any luck?

✖ docker pull ghcr.io/librespeed/speedtest-go:v1.1.5
Error response from daemon: Head "https://ghcr.io/v2/librespeed/speedtest-go/manifests/v1.1.5": unauthorized

✖ docker pull ghcr.io/librespeed/speedtest-go:1.1.5
Error response from daemon: Head "https://ghcr.io/v2/librespeed/speedtest-go/manifests/1.1.5": unauthorized

✖ docker pull ghcr.io/librespeed/speedtest-go:latest
Error response from daemon: Head "https://ghcr.io/v2/librespeed/speedtest-go/manifests/latest": unauthorized
mickkael commented 1 year ago

@onedr0p I have built it just now

https://github.com/mickkael/speedtest-go/pkgs/container/speedtest-go

onedr0p commented 1 year ago

@mickkael is your fork the successor to this repo?

mickkael commented 1 year ago

Not at all. I've built on the fork, as I don't have any permission on the main repo. I've submitted the PR for the same action to be triggered on main repo

onedr0p commented 1 year ago

oh that's a bummer, I guess I'll fork it too and merge some of the PRs here into my fork until the maintainers come back to address them.