search

librespeed / speedtest-go

Go backend for LibreSpeed
GNU Lesser General Public License v3.0
733 stars 157 forks source link

Fix initialization of conf for stats #62

Open balki opened 1 year ago

balki commented 1 year ago

Problem

Even though I set statistics_password in my config (which is /etc/speedtest-settings.toml), I got the message '_Please set statisticspassword in settings.toml to enable access'.

Root cause

In stats.go, global var conf is initialized even before main is called. At this time configFile is empty as it is not set yet. If the config path is not explicitly set using -c flag, viper initializes from settings.toml in current folder. If no settings.toml files is found, conf is initialized with default values and thus does not use the password set in config file.

balki commented 1 year ago

Unintentionally pushed a different change to same branch. Let me know if need to recreate PR with just the original change.