search

librespeed / speedtest

Self-hosted Speed Test for HTML5 and more. Easy setup, examples, configurable, mobile friendly. Supports PHP, Node, Multiple servers, and more
https://librespeed.org
GNU Lesser General Public License v3.0
12.23k stars 2.2k forks source link

errors when changing telemetry_settings.php in entrypoint.sh #406

Closed bes1967 closed 3 years ago

bes1967 commented 3 years ago

Hi First of all - thank you for this software. But after the last update, results/stats.php always shows a warning about the need to specify a password in telemetry_settings.php. This is due to the fact that in entropoint.sh the command: sed -i s/\$Sqlite_db_file\ =\ \".*\"/\$Sqlite_db_file=\"\\/database\\/db.sql\"/g /var/www/html/results/telemetry_settings.php is used to change telemetry_settings.php. and in the file itself the value: $stats_password = 'PASSWORD'; is indicated. Due to the difference in spaces and quotes, no change occurs. The same goes for other variables in telemetry_settings.php. After I changed my telemetry_settings.php (just edit to $stats_password="PASSWORD"; - for example), everything worked. It would be nice to fix this little bug thank you. Update: I'm using Docker image. By the way, same error on $db_type and $enable_id_obfuscation. But handling$Sqlite_db_file is ok.

adolfintel commented 3 years ago

Yeah, I'm stupid and forgot to change the regexes in entrypoint.sh when I did the 5.2.3 release. Should be fixed now.