librespeed / speedtest

Self-hosted Speed Test for HTML5 and more. Easy setup, examples, configurable, mobile friendly. Supports PHP, Node, Multiple servers, and more
https://librespeed.org
GNU Lesser General Public License v3.0
12.1k stars 2.19k forks source link

ISP Spectrum Returns "Unknown ISP" message #592

Closed x-15a2 closed 2 months ago

x-15a2 commented 10 months ago

Description

When running LibreSpeed from Windows 10, ISP Spectrum returns message "Unknown ISP".

Server

New York, United States (2) (Cloudvider) https://librespeed.org

Client

Windows 10 with browsers: (All tested with clean user profiles)

No VPN

Steps to reproduce

Expected behaviour

Should have identified ISP as Spectrum or AS10796 Charter Communications Inc

Screenshots

If necessary, add screenshots of the test.

F12 > Network screenshots can be particularly useful image

sstidl commented 10 months ago

This should be fixed if the owner of the server updates to 5.3

x-15a2 commented 10 months ago

Thanks. I had tried on a few servers, with the same result. Today I went through all servers that are available to me and only the Tokyo, Japan (A573) returned my ISP (as Charter Communications Inc, US). I guess the other servers are in need of the update.

Thanks!

x-15a2 commented 6 months ago

This issue persists, in fact now the Tokyo, Japan (A573) which was previously working now returns the same "Unknown ISP" status.

While I appreciate that servers need to be updated to version 5.3 (or higher), the version is not displayed in the UI, so this information is not user-facing.

So, is it possible for a user to determine the version in use on a specific instance, and is it certain that this issue was corrected in version 5.3 and beyond?

Thanks! 🙂

sstidl commented 6 months ago

Sorry to tell you that I can't reproduce. When I use the Tokyo server it shows the correct result for my IP address

x-15a2 commented 6 months ago

Interesting, and thanks for looking into this. Here are the results that I get: image

The Tokyo server used to identify my ISP as Charter Communication, but now I get unknown ISP, as with all the other LibreSpeed servers.

I've tested the IPINFO API, using IPINFO.IO and it returns the correct ASN. Could the API key be corrupt, or is a 429 error being returned due to too many requests?

x-15a2 commented 3 months ago

Sorry to tell you that I can't reproduce. When I use the Tokyo server it shows the correct result for my IP address

So... are there any additional details that I can provide to try to get this corrected? There's no way (that I've found) to know what version a specific service is on version 5.3 or not. I'm glad that it works for you, but that doesn't resolve the issue. I've supplied add'l details above and have asked for some add'l information, but there has been no response to that, only a comment similar to "it works on my machine".

abdullahdevrel commented 2 months ago

IPinfo DevRel here. I pitched the idea to move from IPinfo's API based system to IPinfo's free IP to Country ASN database: https://github.com/librespeed/speedtest/issues/641

I have seen this issue happen a couple of times, and I think it is due to some networking issues. I believe that if the project moves to the IP database solution, it could reduce network-related issues as the project will be calling the database within the local machine.

Even though we do not require an access token to make call to our API. In fact we permit 1,000 request per day without an access token. But the best option, in my opinion, is opting for the free IP database.

x-15a2 commented 2 months ago

@sstidl Any thoughts on implementing @abdullahdevrel 's above suggestion? My thought is that the 1,000 requests per day are quickly exceeded and there's either no access token or the token has expired. Your thoughts?

Again, this is when running from https://librespeed.org and not from a self-hosted server.

sstidl commented 2 months ago

This was implemented in 5.4.0

x-15a2 commented 2 months ago

Thanks, I appreciate this. I found it working on 2 servers (Serbia SOX and Amsterdam Rust Backend). Just a though (let me know if a new issue should be created for this...) would it be possible to include the version that the server is running? Example:

image