librespot-org / librespot

Open Source Spotify client library
MIT License
4.52k stars 544 forks source link

Update github actions and add Dependabot #1141

Closed yubiuser closed 1 year ago

yubiuser commented 1 year ago

Your github actions are quite outdated, thus triggering deprecation warnings when the workflows run.

This PR will

yubiuser commented 1 year ago

set.output is deprecated, all actions will fail from 1th of June. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

roderickvd commented 1 year ago

Thanks, I'm no expert on this. Let's merge and follow what happens!

roderickvd commented 1 year ago

Actually let's wait until #1140 is in. Otherwise Dependabot will hit us with a million PRs probably 😆

yubiuser commented 1 year ago

Otherwise Dependabot will hit us with a million PRs probably

It should not. Contrary to https://github.com/librespot-org/librespot/pull/713 I did not add the ecosystem "cargo", but only "github-actions". As this PR also updates the actions there should not be a single PR right now.

roderickvd commented 1 year ago

OK here goes!

yubiuser commented 1 year ago

Apparently I forgot a single action/cache occurrence which triggered dependabot. And it seems like it can't deal well with a mixture of major and major.minor.patch dependencies. I'll file a small PR to correct that.

yubiuser commented 1 year ago

https://github.com/librespot-org/librespot/pull/1147