search

librespot-org / librespot

Open Source Spotify client library
MIT License
4.46k stars 540 forks source link

Add devcontainer #1256

Closed yubiuser closed 3 months ago

yubiuser commented 4 months ago

This adds a devcontainer for easier development (e.g. in vscode) using the current MSRV 1.70.0. It's based on the official rust image.

kingosticks commented 4 months ago

I've never used a devcontainer before but I understand they also integrate with GH codespaces. However, am I right that by using an image other than the "default dev container image" will cost money/quota?

yubiuser commented 4 months ago

A dev container is an image with some "sugar" (e.g. editor plugins) on-top. It can be used in different IDE, providing a consistent configuration to build/test the project at hand. GH codespace allows to use custom images as far as I know - but I never used it in GH codespace and can't say anything about their costs. I use it for my local vscode installation. I contribute to different open source projects all requiring different development tools and/or versions. With dev containers I don't need to worry about this, just open the project in the container and everything is setup and I'm good to go.

kingosticks commented 4 months ago

Right, my point is that there is sometimes a choice to use an image that'll also be free for GH codespaces, or one that isn't free. This is the latter. That's fine, but that's the choice made. Maybe at some later time someone who cares enough can fix that.

As it is, seems a good addition.

roderickvd commented 3 months ago

I have no idea about this 😆 so am going by @kingosticks' comments. Thanks.