search

librespot-org / librespot

Open Source Spotify client library
MIT License
4.79k stars 596 forks source link

Fix clippy warnings #1270

Closed yubiuser closed 4 months ago

yubiuser commented 6 months ago

Fixes a clippy warning that occured in recent tests regarding map_clone (https://rust-lang.github.io/rust-clippy/master/index.html#/map_clone) and file creation without explicite defining truncation behavior (https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_open_options)

yubiuser commented 6 months ago

The last commit addressed changes in the beta toolchain that are a consequence of the expansion of redundant import checking. I removed the duplicate imports, another way would be to disable the warning. There is some discussion ongoing regarding the change: https://github.com/rust-lang/rust/issues/121315 https://github.com/rust-lang/rust/issues/121708

roderickvd commented 4 months ago

Thanks a lot for this, great to have the build pass again!