librespot-org / librespot

Open Source Spotify client library
MIT License
4.46k stars 540 forks source link

Update hyper to 1.x #1291

Closed GeorgeHahn closed 3 weeks ago

GeorgeHahn commented 4 weeks ago

This PR updates hyper to version 1.x. I've tested it on windows with default options. The most notable change is in the discovery server, where the code has changed significantly to accommodate changes in hyper. The intent of the code remains the same, and I confirmed that it functions correctly on my devices.

hyper-proxy is swapped out in favor of a maintained fork, hyper-proxy2. I've seen mentions of some alternatives; this appears to be the most stable option.

hyper-rustls is updated to version 0.26.0 to get hyper 1.x support, but is held short of the latest version, 0.27.2, due to build environment changes required for 0.27.0.

Docs I referenced for this change:

roderickvd commented 4 weeks ago

Thanks a lot for this! I went through it and it looks good. If someone could also verify on some *nix?

tstenner commented 3 weeks ago

Built it locally on linux and played back two songs successfully.

roderickvd commented 3 weeks ago

Great, let's merge!