search

librespot-org / librespot

Open Source Spotify client library
MIT License
4.9k stars 627 forks source link

Build failures caused by nasm #1326

Open x528491x opened 2 months ago

x528491x commented 2 months ago

Ever since the version bump for hyper-rustls, nasm becomes a dependency and it creates trouble while building.

Building with cargo build --release works, whereas when using cross, it does not work.

I see that you've also replaced cross with cargo in your build tests.

Would really like a fix for these build errors and the tagging of a new release as simply using the "latest" has become unpredictable

x528491x commented 2 months ago

I just read https://github.com/librespot-org/librespot/pull/1318.

So will cross not work going forward and all cross builds have to be done only with cargo?

roderickvd commented 2 months ago

@yubiuser

x528491x commented 2 months ago

Issue reported upstream

https://github.com/aws/aws-lc-rs/issues/514

x528491x commented 2 months ago

Issue probably fixed upstream:

https://github.com/aws/aws-lc-rs/issues/514#issuecomment-2333908415

yubiuser commented 2 months ago

The issue likely is with cross: it setups a docker container to actually do the build and it uses a fairly outdated base image (esp. if you use the tagged version and not installing from github directly). All dependencies that can't be downloaded as pre-build crates need to find their way into the image used. This can be quite a challenge (this is why I removed cross from librespot). But I see there might be some nasm pre-build crates soon....

roderickvd commented 2 months ago

Fixed now?

fivebanger commented 2 months ago

Edit: Moved to https://github.com/librespot-org/librespot/issues/1346

yubiuser commented 2 months ago

@fivebanger

The error message indicates that your issue is not dircetly related to the issue reported by the OP (and you're not using cross). I would advice to open a new issue to not derail the thread.

fivebanger commented 2 months ago

I have created a new issue.