search

libressl / openbsd

Source code pulled from OpenBSD for LibreSSL - this includes most of the library and supporting code. The place to contribute to this code is via the OpenBSD CVS tree. Please mail patches to tech@openbsd.org, instead of submitting pull requests, since this tree is often rebased.
231 stars 92 forks source link

Missing DSA_meth_set1_name #130

Closed ffontaine closed 2 years ago

ffontaine commented 2 years ago

There is no DSA_meth_set1_name as a result the following build failure is raised with pkcs11-helper since version 3.5.0 and https://github.com/libressl-portable/openbsd/commit/62c7bff5397fa44f595b161cd593d9456eca236e:

pkcs11h-openssl.c: In function 'DSA_meth_set1_name':
pkcs11h-openssl.c:239:41: error: invalid use of incomplete typedef 'DSA_METHOD' {aka 'struct dsa_method'}
  239 |  rv = _pkcs11h_mem_strdup ((void *)&meth->name, name);
      |                                         ^~

Would it be possible to add this function? RSA_meth_set1_name is available since version 2.8.1 and https://github.com/libressl-portable/openbsd/commit/f23a529705e8dc36ad12e26aaa37944a52f1d678.

Full build log: http://autobuild.buildroot.org/results/9b0d3bf7d97696c7be6de1724daaba196626b865

botovq commented 2 years ago

Thanks for the report and apologies for the late reply. I have added DSA_meth_set1_name() and DSA_meth_get0_name(). They will be available in LibreSSL 3.6.0 and later.

4a6f656c commented 2 years ago

This API is available in LibreSSL 3.6.0.