search

libressl / openbsd

Source code pulled from OpenBSD for LibreSSL - this includes most of the library and supporting code. The place to contribute to this code is via the OpenBSD CVS tree. Please mail patches to tech@openbsd.org, instead of submitting pull requests, since this tree is often rebased.
231 stars 92 forks source link

Q: Should leaks found with leak sanitizer in tests/regress be fixed? #81

Closed tamersaadeh closed 6 years ago

tamersaadeh commented 7 years ago

For example on this line one of the BN_new() might not be freed. There are other examples. Are patches needed? If not close this and sorry for the noise.

(PS: I have a Dockerfile with this config based on Ubuntu that I can share if necessary)

4a6f656c commented 6 years ago

The short answer is yes.

The longer answer is that test and regress code tend to be looked at by people who are wanting to write real code, so ensuring that it is written correctly is beneficial. As you note, it also helps to find real issues with analysers/sanitisers, when there is not undo noise.