libretime / client

API clients for LibreTime (experimental)
3 stars 3 forks source link

Fix Python package name #2

Closed jooola closed 2 years ago

jooola commented 2 years ago

Many packages names needs fixing and should follow our naming convention.

The python module should not be libretime.api. The java script package should not belibre_time_api.

paddatrapper commented 2 years ago

The Javascript client needs some investigation, as it ignores the package name parameter passed to it

paddatrapper commented 2 years ago

Suggestions for the python module? libretime.client?

jooola commented 2 years ago

I would prefer not to lock the libretime module/namespace yet, maybe something like libretime_sdk or libretime_client, or even libretime_api_client and we rename the one in the repo to libretime_legacy_client ?

paddatrapper commented 2 years ago

What is holding you back on using the libretime namespace?

jooola commented 2 years ago

Because the generated python module at libretime is actually a module and not a python namespace. If someday we want to start using python namespaces, installing the api client module will prevent this from working.

EDIT: And it isn't consistent with the rest of the python packages we have.

paddatrapper commented 2 years ago

I'm happy with libretime_client then